Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TrackerHit3D once it becomes available #62

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Use TrackerHit3D once it becomes available #62

merged 1 commit into from
Feb 23, 2024

Conversation

tmadlener
Copy link
Contributor

key4hep/EDM4hep#252 renames edm4hep::TrackerHit to edm4hep::TrackerHit3D to immediately re-use TrackerHit for a new type. This PR should make that switch transparent (at least from a building point of view).

@tmadlener tmadlener mentioned this pull request Feb 1, 2024
Merged
10 tasks
@tmadlener tmadlener force-pushed the trackerhit-interface branch from 051271f to 850c4c2 Compare February 22, 2024 12:25
@tmadlener
Copy link
Contributor Author

Not sure why CI is failing, it seems to be unrelated to the changes here. Do we simply need to wait for new nightlies?

@jmcarcell
Copy link
Contributor

Ah indeed, because after removing the lcdd() the class which is pure doesn't have one method implemented. So this should be fine tomorrow. We need this to be able to merge the EDM4hep PR so the nightlies compile and then we can check with new nightlies if all is OK

@kjvbrt kjvbrt merged commit 27b5c0d into HEP-FCC:main Feb 23, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmadlener @jmcarcell @kjvbrt